修复农场模块重大bug：一块土地多次种植不会产生新作物

问题描述：
- 种植逻辑只检查土地状态，未检查是否已存在作物记录
- 收获后作物进入枯萎期但记录仍存在
- 如果土地状态被错误重置为空闲而作物记录未清理，会导致重复种植失败

修复内容：
1. 在CropLogic::plantCrop()中增加作物记录检查
2. 防止在已有作物记录的土地上种植新作物
3. 提供清晰的错误信息和日志记录

测试验证：
- 添加了完整的单元测试
- 创建了命令行测试工具
- 验证了bug场景和正常种植流程

数据库约束：
- 表已有UNIQUE KEY idx_land_id约束
- 代码修复提供更好的用户体验和错误处理

app/Console/Commands/TestCropPlantingBugFix.php

@@ -0,0 +1,154 @@
+<?php
+
+namespace App\Console\Commands;
+
+use App\Module\Farm\Enums\GROWTH_STAGE;
+use App\Module\Farm\Enums\LAND_STATUS;
+use App\Module\Farm\Models\FarmCrop;
+use App\Module\Farm\Models\FarmLand;
+use App\Module\Farm\Models\FarmSeed;
+use App\Module\Farm\Services\CropService;
+use Illuminate\Console\Command;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Log;
+
+/**
+ * 测试作物种植bug修复的命令
+ */
+class TestCropPlantingBugFix extends Command
+{
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'farm:test-planting-bug-fix {user_id} {land_id} {item_id}';
+
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = '测试农场作物种植bug修复';
+
+    /**
+     * Execute the console command.
+     */
+    public function handle()
+    {
+        $userId = (int) $this->argument('user_id');
+        $landId = (int) $this->argument('land_id');
+        $itemId = (int) $this->argument('item_id');
+
+        $this->info("开始测试作物种植bug修复...");
+        $this->info("用户ID: {$userId}, 土地ID: {$landId}, 种子物品ID: {$itemId}");
+
+        // 1. 检查初始状态
+        $this->info("\n=== 1. 检查初始状态 ===");
+        $land = FarmLand::find($landId);
+        if (!$land) {
+            $this->error("土地不存在");
+            return 1;
+        }
+
+        $existingCrop = FarmCrop::where('land_id', $landId)->first();
+        $this->info("土地状态: " . LAND_STATUS::getName($land->status) . " ({$land->status})");
+        $this->info("是否有作物: " . ($land->has_crop ? '是' : '否'));
+        $this->info("作物记录: " . ($existingCrop ? "存在 (ID: {$existingCrop->id}, 阶段: {$existingCrop->growth_stage})" : '不存在'));
+
+        // 2. 模拟bug场景：土地状态为空闲但有作物记录
+        $this->info("\n=== 2. 模拟bug场景 ===");
+        if ($existingCrop) {
+            $this->info("已存在作物记录，模拟土地状态错误重置为空闲的情况");
+            $land->status = LAND_STATUS::IDLE->value;
+            $land->has_crop = false;
+            $land->save();
+            $this->info("已将土地状态重置为空闲，但保留作物记录");
+        } else {
+            $this->info("创建模拟的枯萎作物记录");
+            $seed = FarmSeed::where('item_id', $itemId)->first();
+            if (!$seed) {
+                $this->error("种子配置不存在");
+                return 1;
+            }
+
+            $mockCrop = new FarmCrop();
+            $mockCrop->land_id = $landId;
+            $mockCrop->user_id = $userId;
+            $mockCrop->seed_id = $seed->id;
+            $mockCrop->plant_time = now()->subHours(2);
+            $mockCrop->growth_stage = GROWTH_STAGE::WITHERED;
+            $mockCrop->stage_start_time = now()->subHours(1);
+            $mockCrop->stage_end_time = null;
+            $mockCrop->disasters = [];
+            $mockCrop->fertilized = false;
+            $mockCrop->last_disaster_check_time = now()->subHours(2);
+            $mockCrop->can_disaster = false;
+            $mockCrop->save();
+
+            $land->status = LAND_STATUS::IDLE->value;
+            $land->has_crop = false;
+            $land->save();
+
+            $this->info("已创建模拟枯萎作物记录 (ID: {$mockCrop->id})");
+        }
+
+        // 3. 测试修复后的种植逻辑
+        $this->info("\n=== 3. 测试修复后的种植逻辑 ===");
+        
+        DB::beginTransaction();
+        try {
+            $result = CropService::plantCrop($userId, $landId, $itemId);
+            
+            if ($result) {
+                $this->error("❌ 种植成功了！这表明bug修复可能有问题");
+                $this->info("返回结果: " . json_encode($result, JSON_UNESCAPED_UNICODE));
+            } else {
+                $this->info("✅ 种植失败，符合预期");
+            }
+            
+            DB::rollBack();
+        } catch (\Exception $e) {
+            DB::rollBack();
+            $this->info("✅ 抛出异常，符合预期");
+            $this->info("异常信息: " . $e->getMessage());
+        }
+
+        // 4. 清理并测试正常种植
+        $this->info("\n=== 4. 测试正常种植流程 ===");
+        FarmCrop::where('land_id', $landId)->delete();
+        $land->status = LAND_STATUS::IDLE->value;
+        $land->has_crop = false;
+        $land->save();
+        $this->info("已清理作物记录，土地状态重置为空闲");
+
+        DB::beginTransaction();
+        try {
+            $result = CropService::plantCrop($userId, $landId, $itemId);
+            
+            if ($result) {
+                $this->info("✅ 正常种植成功");
+                $this->info("新作物ID: " . $result['crop']->id);
+                $this->info("种植日志ID: " . $result['log_id']);
+            } else {
+                $this->error("❌ 正常种植失败");
+            }
+            
+            DB::rollBack();
+        } catch (\Exception $e) {
+            DB::rollBack();
+            $this->error("❌ 正常种植抛出异常: " . $e->getMessage());
+        }
+
+        // 5. 清理测试数据
+        $this->info("\n=== 5. 清理测试数据 ===");
+        FarmCrop::where('land_id', $landId)->delete();
+        $land->status = LAND_STATUS::IDLE->value;
+        $land->has_crop = false;
+        $land->save();
+        $this->info("测试数据已清理");
+
+        $this->info("\n测试完成！");
+        return 0;
+    }
+}

app/Module/Farm/Logics/CropLogic.php

@@ -115,6 +115,19 @@ class CropLogic
                 throw new \Exception('土地状态不允许种植');
             }
 
+            // 检查是否已存在作物记录（重要：防止重复种植bug）
+            $existingCrop = FarmCrop::where('land_id', $landId)->first();
+            if ($existingCrop) {
+                Log::warning('土地上已存在作物记录，无法种植新作物', [
+                    'user_id' => $userId,
+                    'land_id' => $landId,
+                    'existing_crop_id' => $existingCrop->id,
+                    'existing_crop_stage' => $existingCrop->growth_stage->value ?? $existingCrop->growth_stage,
+                    'land_status' => $land->status
+                ]);
+                throw new \Exception('土地上已存在作物，请先清理后再种植');
+            }
+
             // 根据物品ID获取种子配置信息
             $seed = FarmSeed::where('item_id', $itemId)->first();
 

tests/Feature/Farm/CropPlantingBugTest.php

@@ -0,0 +1,147 @@
+<?php
+
+namespace Tests\Feature\Farm;
+
+use App\Module\Farm\Enums\GROWTH_STAGE;
+use App\Module\Farm\Enums\LAND_STATUS;
+use App\Module\Farm\Models\FarmCrop;
+use App\Module\Farm\Models\FarmLand;
+use App\Module\Farm\Models\FarmSeed;
+use App\Module\Farm\Services\CropService;
+use App\Module\GameItems\Models\Item;
+use App\Module\GameItems\Services\ItemService;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\DB;
+use Tests\TestCase;
+
+/**
+ * 农场作物种植bug测试
+ * 
+ * 测试场景：一块土地多次种植不会产生新的作物的bug
+ */
+class CropPlantingBugTest extends TestCase
+{
+    /**
+     * 测试种植逻辑是否正确检查现有作物记录
+     */
+    public function test_cannot_plant_when_crop_exists()
+    {
+        // 准备测试数据
+        $userId = 39077; // 使用现有用户
+        $landId = 296;   // 使用现有土地
+        $itemId = 1;     // 种子物品ID
+
+        // 先清理可能存在的作物记录
+        FarmCrop::where('land_id', $landId)->delete();
+
+        // 确保土地状态为空闲
+        $land = FarmLand::find($landId);
+        $this->assertNotNull($land, '土地不存在');
+
+        // 设置土地为空闲状态
+        $land->status = LAND_STATUS::IDLE->value;
+        $land->has_crop = false;
+        $land->save();
+
+        // 确保种子配置存在
+        $seed = FarmSeed::where('item_id', $itemId)->first();
+        $this->assertNotNull($seed, '种子配置不存在');
+
+        // 模拟已存在的作物记录（这是bug的根源）
+        $existingCrop = new FarmCrop();
+        $existingCrop->land_id = $landId;
+        $existingCrop->user_id = $userId;
+        $existingCrop->seed_id = $seed->id;
+        $existingCrop->plant_time = now()->subHours(1);
+        $existingCrop->growth_stage = GROWTH_STAGE::WITHERED; // 枯萎状态
+        $existingCrop->stage_start_time = now()->subHours(1);
+        $existingCrop->stage_end_time = null;
+        $existingCrop->disasters = [];
+        $existingCrop->fertilized = false;
+        $existingCrop->last_disaster_check_time = now()->subHours(1);
+        $existingCrop->can_disaster = false;
+        $existingCrop->save();
+
+        // 开启事务
+        DB::beginTransaction();
+
+        try {
+            // 尝试种植新作物，应该失败
+            $result = CropService::plantCrop($userId, $landId, $itemId);
+            
+            // 验证种植失败
+            $this->assertNull($result, '种植应该失败，因为土地上已存在作物记录');
+            
+            // 验证没有创建新的作物记录
+            $cropCount = FarmCrop::where('land_id', $landId)->count();
+            $this->assertEquals(1, $cropCount, '不应该创建新的作物记录');
+            
+            DB::rollBack();
+        } catch (\Exception $e) {
+            DB::rollBack();
+            
+            // 验证抛出了正确的异常
+            $this->assertStringContainsString('土地上已存在作物', $e->getMessage());
+        }
+
+        // 清理测试数据
+        FarmCrop::where('land_id', $landId)->delete();
+    }
+
+    /**
+     * 测试正常种植流程
+     */
+    public function test_normal_planting_works()
+    {
+        // 准备测试数据
+        $userId = 39077; // 使用现有用户
+        $landId = 296;   // 使用现有土地
+        $itemId = 1;     // 种子物品ID
+
+        // 确保土地状态为空闲且没有作物
+        $land = FarmLand::find($landId);
+        $this->assertNotNull($land, '土地不存在');
+        
+        $land->status = LAND_STATUS::IDLE->value;
+        $land->has_crop = false;
+        $land->save();
+
+        // 清理可能存在的作物记录
+        FarmCrop::where('land_id', $landId)->delete();
+
+        // 确保种子配置存在
+        $seed = FarmSeed::where('item_id', $itemId)->first();
+        $this->assertNotNull($seed, '种子配置不存在');
+
+        // 开启事务
+        DB::beginTransaction();
+
+        try {
+            // 尝试种植新作物，应该成功
+            $result = CropService::plantCrop($userId, $landId, $itemId);
+            
+            // 验证种植成功
+            $this->assertNotNull($result, '种植应该成功');
+            $this->assertArrayHasKey('crop', $result);
+            $this->assertArrayHasKey('log_id', $result);
+            
+            // 验证创建了新的作物记录
+            $newCrop = FarmCrop::where('land_id', $landId)->first();
+            $this->assertNotNull($newCrop, '应该创建新的作物记录');
+            $this->assertEquals(GROWTH_STAGE::SEED->value, $newCrop->growth_stage->value);
+            
+            // 验证土地状态更新
+            $land->refresh();
+            $this->assertEquals(LAND_STATUS::PLANTING->value, $land->status);
+            $this->assertTrue($land->has_crop);
+            
+            DB::rollBack();
+        } catch (\Exception $e) {
+            DB::rollBack();
+            $this->fail('正常种植不应该失败: ' . $e->getMessage());
+        }
+
+        // 清理测试数据
+        FarmCrop::where('land_id', $landId)->delete();
+    }
+}