Merge pull request #58 from YuanHeDx/fix/remove-debugger

fix: remove debugger & rename EffectProps to EffectFuncProps to avoid type name conflict

apps/docs/components/node-form/effect/node-registry.tsx

@@ -1,6 +1,6 @@
 import {
   DataEvent,
-  EffectProps,
+  EffectFuncProps,
   Field,
   FieldRenderProps,
   FormMeta,
@@ -58,7 +58,7 @@ const formMeta: FormMeta<FormData> = {
     field1: [
       {
         event: DataEvent.onValueChange,
-        effect: ({ value }: EffectProps<string, FormData>) => {
+        effect: ({ value }: EffectFuncProps<string, FormData>) => {
           console.log('field1 value:', value);
         },
       },
@@ -66,7 +66,7 @@ const formMeta: FormMeta<FormData> = {
     field2: [
       {
         event: DataEvent.onValueChange,
-        effect: ({ value, form }: EffectProps<string, FormData>) => {
+        effect: ({ value, form }: EffectFuncProps<string, FormData>) => {
           form.setValueIn('field3', 'field2 value is ' + value);
         },
       },

apps/docs/components/node-form/effect/preview.tsx

@@ -12,7 +12,7 @@ import { nodeRegistry } from './node-registry.tsx';
 const nodeRegistryFile = {
   code: `import {
   DataEvent,
-  EffectProps,
+  EffectFuncProps,
   Field,
   FieldRenderProps,
   FormMeta,
@@ -70,7 +70,7 @@ const formMeta: FormMeta<FormData> = {
     field1: [
       {
         event: DataEvent.onValueChange,
-        effect: ({ value }: EffectProps<string, FormData>) => {
+        effect: ({ value }: EffectFuncProps<string, FormData>) => {
           console.log('field1 value:', value);
         },
       },
@@ -78,7 +78,7 @@ const formMeta: FormMeta<FormData> = {
     field2: [
       {
         event: DataEvent.onValueChange,
-        effect: ({ value, form }: EffectProps<string, FormData>) => {
+        effect: ({ value, form }: EffectFuncProps<string, FormData>) => {
           form.setValueIn('field3', 'field2 value is ' + value);
         },
       },

packages/node-engine/form/src/core/form-model.ts

@@ -279,7 +279,6 @@ export class FormModel<TValues = any> implements Disposable {
           const warnings = feedbackToFieldErrorsOrWarnings<Warnings>(path, feedback);
 
           if (field) {
-            debugger;
             field.state.errors = errors;
             field.state.warnings = warnings;
             field.state.invalid = hasError(errors);

packages/node-engine/node/src/types.ts

@@ -51,7 +51,7 @@ export enum DataEvent {
 
 export type EffectReturn = () => void;
 
-export interface EffectProps<TFieldValue = any, TFormValues = any> {
+export interface EffectFuncProps<TFieldValue = any, TFormValues = any> {
   name: FieldName;
   value: TFieldValue;
   prevValue?: TFieldValue;
@@ -61,7 +61,7 @@ export interface EffectProps<TFieldValue = any, TFormValues = any> {
 }
 
 export type Effect<TFieldValue = any, TFormValues = any> = (
-  props: EffectProps<TFieldValue, TFormValues>
+  props: EffectFuncProps<TFieldValue, TFormValues>
 ) => void | EffectReturn;
 
 export type ArrayAppendEffect<TFieldValue = any, TFormValues = any> = (props: {