Bladeren bron

Merge remote-tracking branch 'hver/firePhpRefactor'

Jordi Boggiano 11 jaren geleden
bovenliggende
commit
fe226bf15b
2 gewijzigde bestanden met toevoegingen van 10 en 5 verwijderingen
  1. 5 2
      src/Monolog/Handler/ChromePHPHandler.php
  2. 5 3
      src/Monolog/Handler/FirePHPHandler.php

+ 5 - 2
src/Monolog/Handler/ChromePHPHandler.php

@@ -155,8 +155,11 @@ class ChromePHPHandler extends AbstractProcessingHandler
      */
     protected function headersAccepted()
     {
-        return !isset($_SERVER['HTTP_USER_AGENT'])
-               || preg_match('{\bChrome/\d+[\.\d+]*\b}', $_SERVER['HTTP_USER_AGENT']);
+        if (empty($_SERVER['HTTP_USER_AGENT'])) {
+            return false;
+        }
+
+        return preg_match('{\bChrome/\d+[\.\d+]*\b}', $_SERVER['HTTP_USER_AGENT']);
     }
 
     /**

+ 5 - 3
src/Monolog/Handler/FirePHPHandler.php

@@ -155,9 +155,11 @@ class FirePHPHandler extends AbstractProcessingHandler
      */
     protected function headersAccepted()
     {
-        return !isset($_SERVER['HTTP_USER_AGENT'])
-               || preg_match('{\bFirePHP/\d+\.\d+\b}', $_SERVER['HTTP_USER_AGENT'])
-               || isset($_SERVER['HTTP_X_FIREPHP_VERSION']);
+        if (!empty($_SERVER['HTTP_USER_AGENT']) && preg_match('{\bFirePHP/\d+\.\d+\b}', $_SERVER['HTTP_USER_AGENT'])) {
+            return true;
+        }
+
+        return isset($_SERVER['HTTP_X_FIREPHP_VERSION']);
     }
 
     /**