Просмотр исходного кода

removed the logic for the fallback handler, its out of place, adapted the "test"

odino 12 лет назад
Родитель
Сommit
394b0bf872

+ 1 - 16
src/Monolog/Handler/NewRelicHandler.php

@@ -17,9 +17,7 @@ namespace Monolog\Handler;
  * @see https://newrelic.com/docs/php/new-relic-for-php
  */
 class NewRelicHandler extends AbstractProcessingHandler
-{
-    protected $fallbackHandler;
-    
+{    
     /**
      * {@inheritdoc}
      */
@@ -31,19 +29,6 @@ class NewRelicHandler extends AbstractProcessingHandler
             foreach ($record['context'] as $key => $parameter) {
                 newrelic_add_custom_parameter($key, $parameter);
             }
-        } elseif ($this->fallbackHandler instanceOf AbstractProcessingHandler) {
-            $this->fallbackHandler->write($record);
         }
     }
-
-    /**
-     * Sets the fallback handler to be used to log informations if the New Relic
-     * extension is not available.
-     *
-     * @param Monolog\Handler\AbstractProcessingHandler $handler 
-     */
-    public function setFallbackHandler(AbstractProcessingHandler $handler)
-    {
-        $this->fallbackHandler = $handler;
-    }
 }

+ 1 - 2
tests/Monolog/Handler/NewRelicHandlerTest.php

@@ -20,7 +20,6 @@ class NewRelicHandlerTest extends TestCase
     {
         $handler         = new NewRelicHandler();
         $fallbackHandler = new TestHandler();
-        $handler->setFallbackHandler($fallbackHandler);
         $record          = array(
             'level' => Logger::DEBUG,
             'extra' => array(),
@@ -28,6 +27,6 @@ class NewRelicHandlerTest extends TestCase
         
         $handler->handle($record);
         
-        $this->assertCount(1, $fallbackHandler->getRecords());
+        $this->assertTrue($handler->isHandling($record));
     }
 }