Explorar o código

Change the assert for counting test result values

Malachi Soord %!s(int64=6) %!d(string=hai) anos
pai
achega
021e5a5fe8

+ 1 - 1
tests/Monolog/Handler/BufferHandlerTest.php

@@ -33,7 +33,7 @@ class BufferHandlerTest extends TestCase
         $this->assertFalse($test->hasInfoRecords());
         $this->assertFalse($test->hasInfoRecords());
         $handler->close();
         $handler->close();
         $this->assertTrue($test->hasInfoRecords());
         $this->assertTrue($test->hasInfoRecords());
-        $this->assertTrue(count($test->getRecords()) === 2);
+        $this->assertCount(2, $test->getRecords());
     }
     }
 
 
     /**
     /**

+ 2 - 2
tests/Monolog/Handler/FingersCrossedHandlerTest.php

@@ -35,7 +35,7 @@ class FingersCrossedHandlerTest extends TestCase
         $handler->handle($this->getRecord(Logger::WARNING));
         $handler->handle($this->getRecord(Logger::WARNING));
         $handler->close();
         $handler->close();
         $this->assertTrue($test->hasInfoRecords());
         $this->assertTrue($test->hasInfoRecords());
-        $this->assertTrue(count($test->getRecords()) === 3);
+        $this->assertCount(3, $test->getRecords());
     }
     }
 
 
     /**
     /**
@@ -123,7 +123,7 @@ class FingersCrossedHandlerTest extends TestCase
         $this->assertFalse($test->hasInfoRecords());
         $this->assertFalse($test->hasInfoRecords());
         $handler->handle($this->getRecord(Logger::WARNING));
         $handler->handle($this->getRecord(Logger::WARNING));
         $this->assertTrue($test->hasInfoRecords());
         $this->assertTrue($test->hasInfoRecords());
-        $this->assertTrue(count($test->getRecords()) === 3);
+        $this->assertCount(3, $test->getRecords());
     }
     }
 
 
     /**
     /**

+ 3 - 3
tests/Monolog/Handler/GroupHandlerTest.php

@@ -38,7 +38,7 @@ class GroupHandlerTest extends TestCase
         foreach ($testHandlers as $test) {
         foreach ($testHandlers as $test) {
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasInfoRecords());
             $this->assertTrue($test->hasInfoRecords());
-            $this->assertTrue(count($test->getRecords()) === 2);
+            $this->assertCount(2, $test->getRecords());
         }
         }
     }
     }
 
 
@@ -53,7 +53,7 @@ class GroupHandlerTest extends TestCase
         foreach ($testHandlers as $test) {
         foreach ($testHandlers as $test) {
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasInfoRecords());
             $this->assertTrue($test->hasInfoRecords());
-            $this->assertTrue(count($test->getRecords()) === 2);
+            $this->assertCount(2, $test->getRecords());
         }
         }
     }
     }
 
 
@@ -108,7 +108,7 @@ class GroupHandlerTest extends TestCase
         foreach ($testHandlers as $test) {
         foreach ($testHandlers as $test) {
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasInfoRecords());
             $this->assertTrue($test->hasInfoRecords());
-            $this->assertTrue(count($test->getRecords()) === 2);
+            $this->assertCount(2, $test->getRecords());
             $records = $test->getRecords();
             $records = $test->getRecords();
             $this->assertTrue($records[0]['extra']['foo']);
             $this->assertTrue($records[0]['extra']['foo']);
             $this->assertTrue($records[1]['extra']['foo']);
             $this->assertTrue($records[1]['extra']['foo']);

+ 3 - 3
tests/Monolog/Handler/WhatFailureGroupHandlerTest.php

@@ -38,7 +38,7 @@ class WhatFailureGroupHandlerTest extends TestCase
         foreach ($testHandlers as $test) {
         foreach ($testHandlers as $test) {
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasInfoRecords());
             $this->assertTrue($test->hasInfoRecords());
-            $this->assertTrue(count($test->getRecords()) === 2);
+            $this->assertCount(2, $test->getRecords());
         }
         }
     }
     }
 
 
@@ -53,7 +53,7 @@ class WhatFailureGroupHandlerTest extends TestCase
         foreach ($testHandlers as $test) {
         foreach ($testHandlers as $test) {
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasInfoRecords());
             $this->assertTrue($test->hasInfoRecords());
-            $this->assertTrue(count($test->getRecords()) === 2);
+            $this->assertCount(2, $test->getRecords());
         }
         }
     }
     }
 
 
@@ -108,7 +108,7 @@ class WhatFailureGroupHandlerTest extends TestCase
         foreach ($testHandlers as $test) {
         foreach ($testHandlers as $test) {
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasDebugRecords());
             $this->assertTrue($test->hasInfoRecords());
             $this->assertTrue($test->hasInfoRecords());
-            $this->assertTrue(count($test->getRecords()) === 2);
+            $this->assertCount(2, $test->getRecords());
             $records = $test->getRecords();
             $records = $test->getRecords();
             $this->assertTrue($records[0]['extra']['foo']);
             $this->assertTrue($records[0]['extra']['foo']);
             $this->assertTrue($records[1]['extra']['foo']);
             $this->assertTrue($records[1]['extra']['foo']);